fix(security): address sonar vulnerabilities (#39)

louisgrasset · Oct 20, 2023 · 9d235c0 · 9d235c0
1 parent 09a0e34
commit 9d235c0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,12 +1,17 @@
 FROM node:lts
 
+RUN groupadd --system bot \
+    &&  useradd --system bot -g bot
+
 WORKDIR /app
 
 COPY src/ /app/src
 COPY package.json package-lock.json tsconfig.json .eslintrc.json /app/
 
-RUN npm ci && npm run build
+RUN npm ci --ignore-scripts && npm run build
 
 RUN echo "" > .env
 
+USER bot
+
 CMD node /app/dist/index.js $ENV_FILE
diff --git a/src/helpers/tweet/get-tweet-id-from-permalink.ts b/src/helpers/tweet/get-tweet-id-from-permalink.ts
@@ -1 +1 @@
-export const getTweetIdFromPermalink = (url: string): string => url.match(/\d+$/)?.[0] || '';
+export const getTweetIdFromPermalink = (url: string): string => url.match(/\d{19}$/)?.[0] || '';
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export const getTweetIdFromPermalink = (url: string): string => url.match(/\d+$/)?.[0] \|\| '';
		export const getTweetIdFromPermalink = (url: string): string => url.match(/\d{19}$/)?.[0] \|\| '';