Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade testing libraries #17

Merged
merged 3 commits into from
Oct 1, 2019
Merged

Upgrade testing libraries #17

merged 3 commits into from
Oct 1, 2019

Conversation

bitttttten
Copy link
Contributor

@bitttttten bitttttten commented Oct 1, 2019 •
edited
Loading

I made this upgrade on a few projects of mine too and it's pretty straight forward, I think.

It suppresses this warning:

jest-dom has moved to @testing-library/jest-dom. Please uninstall jest-dom and install @testing-library/jest-dom instead, or use an older version of jest-dom. If you do upgrade to @testing-library/jest-dom, make sure to update your usage of jest-dom to use @testing-library/jest-dom/extend-expect rather than simply jest-dom/extend-expect. Learn more about this change here: testing-library/dom-testing-library#260 Thanks! :)

@lostpebble lostpebble merged commit 5e4d18b into lostpebble:master Oct 1, 2019
@bitttttten bitttttten deleted the chore/upgrade-testing-libraries branch October 1, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitttttten @lostpebble