Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DotNetZip to prevent corrupt zip archives #240

Merged
merged 5 commits into from
Oct 27, 2016
Merged

Update DotNetZip to prevent corrupt zip archives #240

merged 5 commits into from
Oct 27, 2016

Conversation

AndrewBennet
Copy link
Contributor

@AndrewBennet AndrewBennet commented Oct 26, 2016

DotNetZip.Reduced.1.9.1.8 was last updated in 2012. The fork DotNetZip.Semverd is better maintained and fixes an issue with zipping files which are a multiple of 128KB, which causes problems when using ParallelCompression in the Zip task.

This is a fork with some bugfixes. Also added a UnitTest to check that parallel compression zip works for a file which is exactly 128KB.
Previously the unit test was not attempting to unzip the potentially
corrupt zip file. Now it does.
@pwelter34 pwelter34 merged commit 542b6a6 into loresoft:master Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants