Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 17, Babel 7, material-ui 5, Storybook 6 and other deps #36

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

loan-laux
Copy link
Contributor

Fixes #32

As the title says, this updates segmented-control to support React 17. While I was in there, I also updated Babel to version 7, material-ui to version 5, storybook to version 6 and other misc dependencies that were outdated.

@loan-laux
Copy link
Contributor Author

I've just realized that I deleted the package-lock.json file. I thought that I had mistakenly did an npm install on my local version, so I deleted it before pushing. Is it on purpose that we have both a package-lock.json and a yarn.lock?

Signed-off-by: Loan Laux <[email protected]>
@loan-laux
Copy link
Contributor Author

@lorensr I've assumed that package-lock.json and yarn.lock were cohabiting for a reason, so I've put package-lock.json back into place. Let me know if you have any feedback on the PR!

@lorensr lorensr merged commit 8085289 into lorensr:master Jan 20, 2021
@lorensr
Copy link
Owner

lorensr commented Jan 20, 2021

Looks like you added yarn in 2018 😄

https://github.com/lorensr/segmented-control/commits/master/yarn.lock

Published 0.1.13, thanks for the update!

@loan-laux
Copy link
Contributor Author

loan-laux commented Jan 21, 2021

Oh well. I can't remember why I did that.

r_811491_uTXmv

Thanks for merging though, @lorensr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support React 17
2 participants