forked from slic3r/Slic3r
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added Repetier FW flavor, fixed accel gcode generation for it.
Addresses slic3r#3426
- Loading branch information
1 parent
eb49105
commit e0d8101
Showing
6 changed files
with
15 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0d8101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to add Smoothie to ConfigOptionEnum::get_enum_values()
e0d8101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to test this, but when I was mucking around with a post processing script, just setting the X and Y acceleration wasn't enough. Setting X, Y, Z and e did the trick and actually made Repetier accept the acceleration values.
e0d8101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I don't think that it's correct to use M202 with the same acceleration as M201. When printing I want slow printing acceleration, but fast travel moves.
e0d8101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can look at it later tonight. I don't have a printer running Repetier fw myself so I was working from their documentation.
That it requires all of the items to set the acceleration is likely a bug in Repetier.
Setting both travel and print was a compromise. I was not about to add a separate acceleration item just for Repetier at the time. Slic3r changes the acceleration per print move type (and default).
I originally was going to not touch travel acceleration but that would break some assumptions about Slic3r's control of the acceleration.
@bubnikv this commit has nothing to do with Smoothie.
e0d8101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.