Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: add AbstractCollection #268

Closed
wants to merge 4 commits into from
Closed

idea: add AbstractCollection #268

wants to merge 4 commits into from

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Nov 2, 2022

Context from @BusterNeece on Twitter: https://twitter.com/BusterNeece/status/1587570951918870529

This PR:

  • Add an abstract class AbstractCollection to ease the process of extending
  • Update PHPStan baseline (needs review)
  • Update PSalm baseline (needs review)
  • Has documentation
  • It breaks backward compatibility
  • Is covered by unit tests
  • Has static analysis tests (psalm, phpstan)
  • Is an experimental thing

@drupol drupol force-pushed the add-abstract-class branch 17 times, most recently from 6d040c1 to d0a7942 Compare November 2, 2022 22:26
@drupol drupol force-pushed the add-abstract-class branch from d0a7942 to 5a8b57f Compare November 3, 2022 12:32
@drupol drupol mentioned this pull request Nov 3, 2022
7 tasks
@drupol drupol marked this pull request as draft November 4, 2022 09:12
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Since this pull request has not had any activity within the last 5 days, I have marked it as stale.
I will close it if no further activity occurs within the next 5 days.

@github-actions github-actions bot added the stale label Nov 9, 2022
@drupol
Copy link
Collaborator Author

drupol commented Nov 9, 2022

see #270

@drupol drupol closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant