Change GitHub Actions Workflow Triggers #127
Conversation
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| on: | |||
| - pull_request | |||
| - push | |||
There was a problem hiding this comment.
@drupol do you want these to run in master as well, after a merge?
Currently we have them set up like that but I don't know if it was intentional or not: https://github.com/loophp/collection/actions?query=branch%3Amaster
There was a problem hiding this comment.
I don't think it's necessary. All the changes happening in this project should be committed through PRs and not directly in the master branch, so... it will be tested in PRs. WDYT ?
There was a problem hiding this comment.
I think some of the badges on the readme depend on that 🤔
There was a problem hiding this comment.
Fair enough, let's not modify these.
.github/workflows/tests.yml
Outdated
| push: | ||
| branches: | ||
| - master | ||
| pull_request: |
There was a problem hiding this comment.
I decided to keep it on the safe side so this means it runs:
- on pull requests
- on pushes but only to the
masterbranch (effectively after merging a PR as well)
Nice, thanks for that I wasn't using the |
|
Merci :) |
This PR looks to solve workflows triggering multiple times on PRs.