Fix: Prevent warning when using odd amount of items. (#154)

* Fix: Prevent warning when using odd amount of item. * Add tests.
loophp · Jul 18, 2021 · cc52f3d · cc52f3d
1 parent 98b90fe
commit cc52f3d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/spec/loophp/collection/CollectionSpec.php b/spec/loophp/collection/CollectionSpec.php
@@ -2254,6 +2254,18 @@ public function it_can_pair(): void
             ->unwrap()
             ->pair()
             ->shouldIterateAs($gen());
+
+        $input = ['a', 'b', 'c'];
+
+        $gen = static function () {
+            yield 'a' => 'b';
+
+            yield 'c' => null;
+        };
+
+        $this::fromIterable($input)
+            ->pair()
+            ->shouldIterateAs($gen());
     }
 
     public function it_can_partition(): void

diff --git a/src/Operation/Pair.php b/src/Operation/Pair.php
@@ -34,19 +34,19 @@ public function __invoke(): Closure
              * @param TKey $key
              * @param array{0: TKey, 1: T} $value
              *
-             * @return T|TKey
+             * @return T|TKey|null
              */
-            static fn ($initial, $key, array $value) => $value[0];
+            static fn ($initial, $key, array $value) => $value[0] ?? null;
 
         $callbackForValues =
             /**
              * @param T $initial
              * @param TKey $key
              * @param array{0: TKey, 1: T} $value
              *
-             * @return T|TKey
+             * @return T|TKey|null
              */
-            static fn ($initial, $key, array $value) => $value[1];
+            static fn ($initial, $key, array $value) => $value[1] ?? null;
 
         /** @var Closure(Iterator<TKey, T>): Generator<T|TKey, T> $pipe */
         $pipe = Pipe::of()(