go: preserve nil structs on decode #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decoding a struct with struct fields, the generated `decode()` method would replace the `nil` fields with an empty new struct. Since `nil` fields are stored in the original message with zero bytes (`0x00`), we can check for it before attempting to decode the field into an intialized zero value. Signed-off-by: Luiz Aoqui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decoding a struct with struct fields, the generated
decode()method would replace thenilfields with an empty new struct. Sincenilfields are stored in the original message with zero bytes (0x00), we can check for it before attempting to decode the field into an intialized zero value.