refactor: extract decode user to util #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannyHou
force-pushed
the
auth/util-refactor
branch
from
39ba47f to
eab5f0e
Compare
jannyHou
force-pushed
the
auth/util-refactor
branch
from
eab5f0e to
9de6315
Compare
jannyHou
commented
Jan 25, 2019
| @@ -46,3 +48,15 @@ export function validateCredentials(credentials: Credentials) { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| // secret should be injected | |||
There was a problem hiding this comment.
This is implemented in the next PR #33
bajtos
approved these changes
Jan 28, 2019
Signed-off-by: jannyHou <[email protected]>
jannyHou
force-pushed
the
auth/util-refactor
branch
from
115b261 to
7dbe015
Compare
bajtos
reviewed
Jan 31, 2019
| const token = 'fake'; | ||
| try { | ||
| await decodeAccessToken(token, SECRET); | ||
| expect('throws error').to.be.true(); |
There was a problem hiding this comment.
Here is a better way for verifying that a call of an async function throws an error:
await expect(decodeAccessToken(token, SECRET))
.to.be.rejectedWith('jwt malformed');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect to loopbackio/loopback-next#1997
previous PR: #26
Refactor the decoding user code into a util function, so that it could be shared among different controllers other than REST.