Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add DateString type #373

Merged
merged 1 commit into from
May 2, 2017
Merged

types: add DateString type #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pages/en/lb3/LoopBack-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,17 @@ The following table summarizes LoopBack's data types.
<pre>new GeoPoint({lat: 10.32424, lng: 5.84978});</pre>
</td>
</tr>
<tr>
<td>DateString</td>
<td>
<p>LoopBack<a href="http://apidocs.strongloop.com/loopback-datasource-juggler/#datestring" class="external-link" rel="nofollow"> DateString</a> object</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we have an anchor for #datestring in the apidoc?

Copy link
Contributor

@jannyHou jannyHou May 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no tag with id datestring on that page. Other than that LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, this link doesn't exist. I presume there is a PR somewhere for it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that's what @kjdelisle is talking about re loopbackio/loopback-datasource-juggler#1356. Once that lands (with some modifications) and juggler is published to npm, then the link should work.

</td>
<td>
<p><code>"2000-01-01T00:00:00.000Z"</code></p>
<p><code>"2000-01-01"</code></p>
<p><code>"2000-01-01 12:00:00"</code></p>
</td>
</tr>
<tr>
<td>null</td>
<td>JSON null</td>
Expand Down