feat(cli): add scoped debugging #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjdelisle
force-pushed
the
cli/enhance-debugging
branch
2 times, most recently
from
e8d09fd to
ae3e380
Compare
raymondfeng
reviewed
Jan 3, 2018
| @@ -18,6 +20,7 @@ module.exports = class ControllerGenerator extends ArtifactGenerator { | |||
| type: 'controller', | |||
| outdir: 'src/controllers/', | |||
| }; | |||
| debug(`artifactInfo: ${inspect(this.artifactInfo)}`); | |||
There was a problem hiding this comment.
Can we wrap the debug statement as follows to avoid the parameter calculation if debug is not on?
if (debug.enabled) {
debug(`artifactInfo: ${inspect(this.artifactInfo)}`);
}
ae3e380 to
a6045aa
Compare
added 2 commits
January 3, 2018 13:54
Allows scoping of debug messages to specific modules (or whatever custom scope is desired)
kjdelisle
force-pushed
the
cli/enhance-debugging
branch
from
a6045aa to
1c23e7e
Compare
raymondfeng
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add scoped debugging to the CLI module, as well as some new debugging statements to the artifact-generator and the controller-generator.
Adding these statements to make my life easier when building the feature for the linked issue.
Related issues
connected to #727
Checklist