Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin swagger-ui-dist to v3.30.0 #5991

Merged
merged 1 commit into from
Jul 22, 2020
Merged

fix: pin swagger-ui-dist to v3.30.0 #5991

merged 1 commit into from
Jul 22, 2020

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Jul 22, 2020

Related to swagger-api/swagger-ui#6249

When clicked on the /ping controller, there is only loading icon.
image (5)

This fix is suggested by @raymondfeng to revert to use 3.30.0.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau requested a review from hacksparrow as a code owner July 22, 2020 15:07
@raymondfeng
Copy link
Contributor

The commit message should say pin swagger-ui-dist to v3.30.0 and reference the issue in the body.

"version": "1.19.0",
"resolved": "https://registry.npmjs.org/@types/body-parser/-/body-parser-1.19.0.tgz",
"integrity": "sha512-W98JrE0j2K78swW4ukqMleo8R7h/pFETjM2DQ90MF6XK2i4LO4W3gQ71Lt4w3bfm2EvVSyWHplECvB5sK22yFQ==",
"@babel/code-frame": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that some @babel/ dependencies are added incorrectly. Please run node bin/rebuild-package-locks.js @loopback/rest-explorer to fix it.

@dhmlau dhmlau changed the title fix: revert swagger-ui-dist version fix: pin swagger-ui-dist to v3.30.0 Jul 22, 2020
@dhmlau dhmlau merged commit e4ec09e into master Jul 22, 2020
@dhmlau dhmlau deleted the swagger-ui branch July 22, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants