Auth doc refactor #5598
Merged
Auth doc refactor #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhmlau
reviewed
May 29, 2020
| strategy, the diagram below shows how such authentication process works with | ||
| LoopBack's authentication mechanism. | ||
|
|
||
|  |
There was a problem hiding this comment.
there're extra icons at the bottom right. Could you please remove that?
There was a problem hiding this comment.
The diagram is created kinda in a rush, I will draw it again.
There was a problem hiding this comment.
@dhmlau I updated the diagram.
docs/site/Authentication-overview.md
Outdated
| authentication. | ||
| - [How to create your own authentication strategy](missing_link): Particularly | ||
| for extension developers. | ||
| - [Use [Passport](https://www.npmjs.com/package/passport) strategies](missing |
There was a problem hiding this comment.
@dhmlau sure, I am creating sub-PRs to update each page, and eventually the links will all be updated.
achrinza
reviewed
May 29, 2020
agnes512
reviewed
May 29, 2020
madaky
reviewed
May 29, 2020
jannyHou
commented
Jun 2, 2020
jannyHou
commented
Jun 2, 2020
jannyHou
commented
Jun 2, 2020
jannyHou
commented
Jun 2, 2020
jannyHou
commented
Jun 2, 2020
jannyHou
changed the title
This was referenced Jun 2, 2020
Merged
jannyHou
force-pushed
the
auth-doc-refactor
branch
from
055f2b7
to
b9ae852
Compare
This was referenced Jun 7, 2020
jannyHou
changed the title
jannyHou
force-pushed
the
auth-doc-refactor
branch
from
b2d3ef6
to
122f83e
Compare
raymondfeng
reviewed
Jun 10, 2020
dhmlau
reviewed
Jun 10, 2020
dhmlau
approved these changes
Jun 10, 2020
jannyHou
force-pushed
the
auth-doc-refactor
branch
from
4c34722
to
eed4321
Compare
jannyHou
force-pushed
the
auth-doc-refactor
branch
from
eed4321
to
5059507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to #5294
The first auth doc refactor PR: overview page
Please review file docs/site/Authentication-overview.md ONLY, the others files are merged from other PRs.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈