Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add model to rest api docs #4976

Merged
merged 1 commit into from
Mar 27, 2020
Merged

docs: add model to rest api docs #4976

merged 1 commit into from
Mar 27, 2020

Conversation

nabdelgadir
Copy link
Contributor

Closes #2740.

Documentation for application developers to use @loopback/rest-crud and extension developers to use @loopback/model-api-builder.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@nabdelgadir nabdelgadir self-assigned this Mar 26, 2020
@nabdelgadir
Copy link
Contributor Author

Coverage decrease is unrelated but it dropped because sometimes the geocoder test will throw 502 and skip this line even though we check if the service is available before running related tests.

Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't know the details but the content is understandable to me.
I have 2 review comments.

docs/site/Creating-CRUD-REST-apis.md Outdated Show resolved Hide resolved
docs/site/Creating-CRUD-REST-apis.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM

docs/site/Creating-CRUD-REST-apis.md Outdated Show resolved Hide resolved
docs/site/Extending-Model-API-builder.md Outdated Show resolved Hide resolved
Documentation for application developers to use `@loopback/rest-crud` and extension developers to use `@loopback/model-api-builder`.
@nabdelgadir nabdelgadir merged commit 4cd844b into master Mar 27, 2020
@nabdelgadir nabdelgadir deleted the restcruddocs branch March 27, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs for exposing REST API of a Model with no custom classes
4 participants