docs: migrate loopback-example-passport repo as lb4 example #4899

deepakrkris · 2020-03-16T23:53:25Z

satisfies: #2624

Test steps

** This example repo would need manual test

preconditions: create a test app and test user in facebook, and make sure to give email permission to test user. (emonddr : visit https://developers.facebook.com to do this.)
preconditions: Copy test app's client id and secret and update those in the examples/passport-poauth2-login/authentication-strategies/oauth2-strategy.ts
Run npm i from loopback-next root folder, to create symlinks with master packages
cd examples/passport-oauth2-login & npm start
open browser -> http://localhost:3000 (emonddr : Open a new window in Incognito mode, otherwise may not work)
click login -> login with facebook
page redirects to facebook, enter test user credentials
if authentication was successful, page redirects to login profiles page and shows linked facebook account details along with access token

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Documentation in /docs/site was updated
Affected artifact templates in packages/cli were updated
Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

emonddr

Great job, Deepak. I left questions and comments. Also, please make sure any comments from #4919 that also have relevance here are applied accordingly. thx.

emonddr · 2020-03-30T18:05:29Z

examples/passport-oauth2-login/src/authentication-strategies/redirect-route.ts

@@ -0,0 +1,68 @@
+// Copyright IBM Corp. 2019. All Rights Reserved.
+// Node module: @loopback/rest


I've noticed in a few files the Node module comment seems to have different values:

// Node module: @loopback/authentication or @loopback/rest

Please make them all the same value appropriate for this example. See other examples. thx.

emonddr · 2020-03-30T18:08:33Z

examples/passport-oauth2-login/src/authentication-strategies/strategy-adapter.ts

+ *   4. provides state methods to the strategy instance
+ * see: https://github.com/jaredhanson/passport
+ */
+export class StrategyAdapter<U> {


Why is another strategy adapter being defined here? you should use: https://github.com/strongloop/loopback-next/blob/master/extensions/authentication-passport/src/strategy-adapter.ts .

Were you waiting for #4919 to land?

hey @emonddr yes exactly, I was waiting for 4919 to be landed, the changes will have to be published as well.

symlinks with master package is enabled now, please see PR description for manual test steps

emonddr · 2020-03-30T18:14:05Z

examples/passport-oauth2-login/src/authentication-strategies/oauth2-strategy.ts

+import {User} from '../models';
+import {asSpecEnhancer, OASEnhancer} from '@loopback/openapi-v3';
+
+const options: StrategyOption = {


Are these real ids? Perhaps remove them?

@emonddr , yep I created a test app in facebook, it is not a security risk as of now. but I am going to remove it shortl

emonddr · 2020-03-30T18:15:33Z

examples/passport-oauth2-login/src/authentication-strategies/oauth2-strategy.ts

+    );
+  }
+  modifySpec(
+    spec: import('@loopback/rest').OpenAPIObject,


What is being done here exactly? What is being added to the app's open api spec? thx.

this is not relevant, removed now.

emonddr · 2020-03-30T18:16:40Z

examples/passport-oauth2-login/src/authentication-strategies/oauth2-strategy.ts

+  ) {
+    const userProfile: UserProfile = mapFaceBookProfile(profile);
+    this.userService
+      .findOrCreateExternalUser(userProfile)


What is meant by external user? If you could clarify. thx.

we are creating a local profile on behalf of an external provider, added additional comments to clarify this now.

emonddr · 2020-03-30T18:18:27Z

examples/passport-oauth2-login/src/authentication-strategies/redirect-route.ts

+    response.redirect(this.statusCode, this.targetLocation);
+  }
+
+  updateBindings(requestContext: RequestContext) {


Do we need this as an empty method? Please clarify. thx.

agreed, removed

emonddr · 2020-03-30T18:20:37Z

examples/passport-oauth2-login/src/models/access-token.model.ts

+
+import {Entity, model, property} from '@loopback/repository';
+
+@model({settings: {strict: false}})


Why are settings required in the @model decorator?

This link https://loopback.io/doc/en/lb4/Model.html#using-the-juggler-bridge shows 2 examples. One where no settings are placed in @model decorator, and one with . If you could elaborate. thx.

I am still looking at this

I have removed the strict: false setting now

jannyHou · 2020-03-30T19:29:52Z

examples/passport-oauth2-login/src/authentication-strategies/auth-action.provider.ts

+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+
+import {Getter, inject, Provider, Setter} from '@loopback/context';


Hmm, wouldn't this action be provided by the @loopback/authentication module?

jannyHou · 2020-03-30T19:56:49Z

examples/passport-oauth2-login/src/authentication-strategies/strategy-adapter.ts

+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+
+import {UserProfileFactory} from '@loopback/authentication';


I think we should leverage the adapter from https://github.com/strongloop/loopback-next/tree/master/extensions/authentication-passport

agreed, symlinks to master packages enabled now.

raymondfeng · 2020-03-31T20:47:55Z

examples/passport-oauth2-login/package.json

@@ -0,0 +1,67 @@
+{
+  "name": "passport-oauth2-login",


The name should be something like @loopback/example-passport-oauth2.

raymondfeng · 2020-03-31T20:48:24Z

examples/passport-oauth2-login/index.js

@@ -0,0 +1,29 @@
+const application = require('./dist');


Copyright/license header is missing.

raymondfeng · 2020-03-31T20:48:45Z

examples/passport-oauth2-login/client/web-app.js

@@ -0,0 +1,93 @@
+// Copyright IBM Corp. 2014,2015. All Rights Reserved.
+// Node module: loopback-example-passport


The module name does not match package.json.

emonddr · 2020-04-13T13:16:59Z

@deepakrkris , please see my comments from 4 to 5 days ago. Thanks.

deepakrkris · 2020-04-13T16:39:12Z

In addition to the controllers you have, which seem to involve logging in (local) and oauth callbacks (oauth2), I would suggest the default ping controller that is automatically built for an lb4 app (and requires no authentication), and create another controller with an endpoint that prints out currently logged in user as a response. Decorate this method with @authenticate('oauth2'). This would show the we can access the /ping endpoint with or without being logged in, and the /printme endpoint only if we are properly logged in.

@emonddr the authentication endpoints are used in this example to create an authenticated user session for the express web application. This is similar to https://github.com/strongloop/loopback-example-passport . To authenticate the api endpoints we would need to add a different authentication strategy like 'jwt'.

deepakrkris · 2020-04-13T16:40:02Z

And for some reason, my db.json ends up with many test users

  "models": {
    "User": {
      "3": "{\"name\":\"Test User\",\"username\":\"[email protected]\",\"email\":\"[email protected]\",\"id\":3}",
      "4": "{\"name\":\"Test User\",\"username\":\"[email protected]\",\"email\":\"[email protected]\",\"id\":4}",
      "5": "{\"name\":\"Test User\",\"username\":\"[email protected]\",\"email\":\"[email protected]\",\"id\":5}",
      "6": "{\"name\":\"Test User\",\"username\":\"[email protected]\",\"email\":\"[email protected]\",\"id\":6}",
      "7": "{\"name\":\"Test User\",\"username\":\"[email protected]\",\"email\":\"[email protected]\",\"id\":7}",

I have restarted several times. I this done on startup?
I've never used this user.

@emonddr thanks for testing this. I have fixed this now.

deepakrkris · 2020-04-13T16:44:16Z

I like the UI, by the way

I was thinking we should only show certain menu options when they are applicable.
e.g. Let's not show Logout until someone is actually logged in
Let's not show Sign Up, Sign Up Options, Login when someone is logged in

agree that the menu is very naive, but I just copied most of the UI templates from https://github.com/strongloop/loopback-example-passport

deepakrkris · 2020-04-13T16:46:29Z

If I click on Sign Up,
and specify my data (not associated with social media)
dom emond
[email protected]
etc

I get redirected to /login
and I am able to login

Like above [View Account] has no info about me.

When I try to Log out

I get an error

@emonddr the logout function is fixed now . I have also added acceptance test cases for these scenarios.

deepakrkris · 2020-04-13T16:48:20Z

Clicking on the [Server Status] link on the website,

I get an error

Clicking Logout I get this:

The Server status was a OOTB functionality in lb3. I have removed that link now. Logout had an error, I have fixed that now.

deepakrkris · 2020-04-13T16:49:28Z

Regarding

preconditions: create a test app and test user in facebook, and make sure to give email permission to test user

This is actually quite confusing for someone who has never gone here. I have, but never set up a user. So a detailed step by step description of what to do including links would be helpful.

@emonddr I have added details on facebook login in the README.md now.

emonddr · 2020-04-13T17:18:32Z

@emonddr the authentication endpoints are used in this example to create an authenticated user session for the express web application. This is similar to https://github.com/strongloop/loopback-example-passport . To authenticate the api endpoints we would need to add a different authentication strategy like 'jwt'.

@deepakrkris , apologies. I don't follow. Isn't the whole purpose of this example to see how someone can use facebook or google login to get authenticated, and then get access to LB4 APIs?

deepakrkris · 2020-04-13T17:21:08Z

@emonddr the authentication endpoints are used in this example to create an authenticated user session for the express web application. This is similar to https://github.com/strongloop/loopback-example-passport . To authenticate the api endpoints we would need to add a different authentication strategy like 'jwt'.

@deepakrkris , apologies. I don't follow. Isn't the whole purpose of this example to see how someone can use facebook or google login to get authenticated, and then get access to LB4 APIs?

@emonddr the purpose is to authenticate with facebook/google, YES. But not to validate user access to other LB4 APIs, but to validate access to the express web application. In this case the path /auth/account is the only page that gets validated for a user session.

emonddr · 2020-04-13T20:53:12Z

@deepakrkris , I don't see belongsTo decorator in UserIdentity or UserCredential but User has @hasone and @hasmany respectively. Also in latest commit, if you are using rest-crud to create user endpoints, I don't think it handles relations at the moment. @nabdelgadir , I saw this in your blog. Can you confirm? thx. @agnes512 , can you chime in on this as well? In a hasMany or hasOne, there must be a belongsTo on the other side of the relation right? @belongsTo is not optional, correct?

Also, perhaps rename : examples/passport-login/src/controllers/user.controller.ts to user-signup-login.controller.ts since user.controller.ts is usually created for a user model for all its endpoints.

emonddr · 2020-04-14T13:32:18Z

examples/passport-login/data/db.json

-    "UserCredentials": 3
+    "User": 9,
+    "UserIdentity": 104566694532676,
+    "UserCredentials": 4


Is it possible for the this file to zero entries in User, UserIdentity, and UserCredentials, and have the "ids" have entries with value 1 or something. Right now the "ids".UserCredentials is 4, but looking in UserCredentials, the userId is 6. So it looks weird.

@emonddr I have enabled clearing test data after every test run

emonddr · 2020-04-14T13:41:14Z

examples/passport-login/src/controllers/ping.controller.ts

+export class PingController {
+  constructor(@inject(RestBindings.Http.REQUEST) private req: Request) {}
+
+  @authenticate('session')


User should always be able to visit /ping without authentication (even if logged in with an auth strategy)

Let's leave the /ping without the @authenticate decorator

but have another endpoint in this controller like

@authenticate('session')
@get(/whoAmi )
which returns the currently logged in user.

What will the request headers show?

+1, /whoAmI or /me prints the user info, /ping is usually public.

agreed, this is done now

emonddr · 2020-04-14T13:46:13Z

@deepakrkris , thanks for addressing my comments yesterday. We're almost there.

emonddr · 2020-04-14T15:06:07Z

@deepakrkris , I don't see belongsTo decorator in UserIdentity or UserCredential but User has @hasone and @hasmany respectively. Also in latest commit, if you are using rest-crud to create user endpoints, I don't think it handles relations at the moment. @nabdelgadir , I saw this in your blog. Can you confirm? thx. @agnes512 , can you chime in on this as well? In a hasMany or hasOne, there must be a belongsTo on the other side of the relation right? @belongsTo is not optional, correct?

Also, perhaps rename : examples/passport-login/src/controllers/user.controller.ts to user-signup-login.controller.ts since user.controller.ts is usually created for a user model for all its endpoints.

Hi @deepakrkris , so I spoke with @agnes512 . So it turns out you were correct. You don't need the belongsTo in UserCredential and UserIdentity if you don't plan on navigating from any of these back to the original User. If you only need to navigate from User to UserIdentity or User to UserCredentials, then you only need the hasMany and hasOne. If you need to navigate from parent to child and child to parent, then you need to use hasMany and belongsTo, or hasOne and belongsTo.
If you define this bi-directional navigation, even if you don't use it, it is fine, it doesn't break anything. And for me, personally, it gives me a nice fuzzy feeling to define both to help clearly define their relationship.

jannyHou

@deepakrkris Great effort!!! a few questions & suggestions(commented with details):

the method in the ping controller looks good in general, but it's better to have it in the existing user controller and transfer the method to /whoAmI or /me
renaming UserIdentity?
maybe more explanation about the the app/server structure
data in db.json

I need more time to review each file in details but other than questions above I don't see obvious problem.

jannyHou · 2020-04-14T15:17:28Z

packages/authentication/src/services/user-identity.service.ts

+export interface UserIdentityService<I, U> {
+  /**
+   * find or create a local user using a profile from an external source
+   * @param userIdentity


maybe write it more clear that userIdentity here refers to the external identity.

jannyHou · 2020-04-14T15:29:12Z

examples/passport-login/src/services/user.service.ts

+  ): Promise<User> {
+    let profile;
+    try {
+      profile = await this.userIdentityRepository.findById(userIdentity.id);


Followed the conversation here, a suggestion for UserIdentity: maybe rename it to something that clearly say it's an EXTERNAL identity?

Like ExternalIdentity, ThirdPartyIdentity? just to distinguish it with the local UserPorfile.

Same for the newly added interface UserIdentity in @loopback/authentication.
WDYT? cc @deepakrkris @emonddr

Feel free to ignore it if it's only my own concern :) I understand that renaming takes huge refactor effort.

jannyHou · 2020-04-14T15:34:34Z

examples/passport-login/src/server.ts

+ *       a. LB4 application provides passport login services for the express app
+ *       b. The LB4 login apis are wrapped with session middleware to allow client sessions with user profiles
+ */
+export class ExpressServer {


I am confused about the server+app structure here...so you setup an express server, and use the webApp and lbApp as two routers?

jannyHou · 2020-04-14T15:38:22Z

examples/passport-login/data/db.json

+      "1003": "{\"id\":\"1003\",\"provider\":\"custom-oauth2\",\"profile\":{\"emails\":[{\"value\":\"[email protected]\"}]},\"authScheme\":\"custom-oauth2\",\"created\":\"2020-04-13T22:01:23.556Z\",\"userId\":6}",
+      "104566694532668": "{\"id\":\"104566694532668\",\"provider\":\"facebook\",\"profile\":{\"emails\":[{\"value\":\"[email protected]\"}]},\"authScheme\":\"facebook\",\"created\":\"2020-04-13T23:18:46.875Z\",\"userId\":8}"
+    },
+    "UserCredentials": {


one User should have one UserCredentials, any reason the db here has 3 users but only 1 entry of credentials..?

jannyHou · 2020-04-14T15:40:11Z

examples/passport-login/src/controllers/ping.controller.ts

+export class PingController {
+  constructor(@inject(RestBindings.Http.REQUEST) private req: Request) {}
+
+  @authenticate('session')


+1, /whoAmI or /me prints the user info, /ping is usually public.

deepakrkris · 2020-04-15T15:19:45Z

@deepakrkris Great effort!!! a few questions & suggestions(commented with details):

the method in the ping controller looks good in general, but it's better to have it in the existing user controller and transfer the method to /whoAmI or /me

renaming UserIdentity?

maybe more explanation about the the app/server structure

data in db.json

I need more time to review each file in details but other than questions above I don't see obvious problem.

Hey @jannyHou thanks for the review,

I have added endpoint '/whoAmI' to print the current user , as per your suggestion
UserIdentity is a term borrowed from the original loopback-component-passport , since this is a migration story, may be better to have it for now.
The server structure is Express Composition , we already have examples in detail for it
The user credentials are created only for locally signed up users. This is also borrowed from the loopback-component-passport. We can change that after completing this migration story.

emonddr

Great improvements since last time. thank you.

Please update the instructions on how to interact with sample. I have a added a suggested list. Also, I am still seeing a JSON object as a string on the Login screen after I sign up with facebook.

emonddr · 2020-04-16T15:11:15Z

examples/passport-login/README.md

+$ npm start
+```
+
+- Open your browser to the example app with, `http://localhost:3000`


@deepakrkris , thanks for making the UI changes and addressing my earlier comments.

Let's update this section with the latest UI changes in mind (some of the instructions are out of date.)

But also it is important to register a local user BEFORE any social media login, otherwise there will be issues.

Open browser to localhost:3000

Sign up as a local user with the email of a facebook test user you created above, and provide a password for local purposes. This registers a local user, and it will eventually be linked to social media credentials in the following steps.

Login as this local user. You will be brought to the "View Account" tab ( and describe what they should see)

Click on Sign Up or Login, and the pages indicate you've already logged in.

Click on [Current User] button, and it calls https://localhost:3000/api/whoAmI endpoint and displays currently authenticated user.

Click on Logout.

Click on View Account, and you are not permitted since you are logged out.

Look at the db.json and mention what they should see in there. User with specific email, and in UserCredentials, the password you enterered when you signed up.

Now click on Login, and choose Login with Facebook. Enter the email of your facebook test user (same email you entered above), but specify the test user's facebook password (not local password).

Upon successful FaceBook login, you are brought to View Account. (Explain the data they should see)

Click on Sign Up or Login, and the pages indicate you are already logged in.

Click on [Current User] to view the currently authenticated user.

Click on Logout

Click on View Account, and you are not allowed.

Look at the db.json, there is still one user. It still has the UserCredentials entry as earlier, But now there is an entry in the UserIdentity section which contains the facebook profile info.
At any time (authenticated or not), open http://localhost:3000/api/ping in the browser and you should see the ping info returned. This endpoint doesn't require authentication.

Please re-word my list above to your liking. But we need to hold the user's hand to explain our UI to have a sense of what the ui can do based on the endpoints we've secured. As well as the database info that helps tie the local and social stuff together.

@emonddr agreed, this is fixed now

@deepakrkris , thanks for making the UI changes and addressing my earlier comments.

Let's update this section with the latest UI changes in mind (some of the instructions are out of date.)

But also it is important to register a local user BEFORE any social media login, otherwise there will be issues.

Open browser to localhost:3000

Sign up as a local user with the email of a facebook test user you created above, and provide a password for local purposes. This registers a local user, and it will eventually be linked to social media credentials in the following steps.

Login as this local user. You will be brought to the "View Account" tab ( and describe what they should see)

Click on Sign Up or Login, and the pages indicate you've already logged in.

Click on [Current User] button, and it calls https://localhost:3000/api/whoAmI endpoint and displays currently authenticated user.

Click on Logout.

Click on View Account, and you are not permitted since you are logged out.

Look at the db.json and mention what they should see in there. User with specific email, and in UserCredentials, the password you enterered when you signed up.

Now click on Login, and choose Login with Facebook. Enter the email of your facebook test user (same email you entered above), but specify the test user's facebook password (not local password).

Upon successful FaceBook login, you are brought to View Account. (Explain the data they should see)

Click on Sign Up or Login, and the pages indicate you are already logged in.

Click on [Current User] to view the currently authenticated user.

Click on Logout

Click on View Account, and you are not allowed.

Look at the db.json, there is still one user. It still has the UserCredentials entry as earlier, But now there is an entry in the UserIdentity section which contains the facebook profile info.
At any time (authenticated or not), open http://localhost:3000/api/ping in the browser and you should see the ping info returned. This endpoint doesn't require authentication.

Please re-word my list above to your liking. But we need to hold the user's hand to explain our UI to have a sense of what the ui can do based on the endpoints we've secured. As well as the database info that helps tie the local and social stuff together.

@emonddr I have incorporated these steps as suitable for user readability. please review.

jannyHou

A few minor suggestions LGTM :)
I'll leave the UI related code review for Dom, thanks!

jannyHou · 2020-04-17T01:07:00Z

examples/passport-login/src/__tests__/acceptance/passport-login.acceptance.ts

+        expect(url.parse(callbackToLbApp).query).to.containEql('code');
+      });
+
+      it('access code can be exchanged for token', async () => {


hmm how does the code and token exchange get tested in it?

authorization code exchange test is also done in acceptance tests of extension-passport

jannyHou · 2020-04-17T01:18:25Z

examples/passport-login/src/authentication-strategies/google.ts

+   * map passport profile to user profile
+   * @param user
+   */
+  mapProfile(user: User): UserProfile {


If the mapProfile functions are same in all strategies, you can extract them into utils.

jannyHou · 2020-04-17T01:27:33Z

examples/passport-login/src/authentication-strategies/oauth2.ts

+}
+
+@bind(asAuthStrategy)
+export class Oauth2AuthStrategy implements AuthenticationStrategy {


@emonddr The auth provider should be decorated with @extensionPoint, see example in https://loopback.io/doc/en/lb4/Loopback-component-authentication.html#registering-a-custom-authentication-strategy

The class here is just an auth strategy.

jannyHou · 2020-04-17T01:35:01Z

examples/passport-login/src/authentication-strategies/oauth2.ts

+}
+
+@bind(asAuthStrategy)
+export class Oauth2AuthStrategy implements AuthenticationStrategy {


@emonddr @deepakrkris See the comment in https://github.com/strongloop/loopback-next/blob/master/packages/core/src/extension-point.ts#L67-L71

The extension name can be provided directly by the 1st param in @extensions(), @extensionPoint() is another way to provide the name.
That's why Deepak's code works.

jannyHou · 2020-04-17T01:36:53Z

examples/passport-login/src/authentication-strategies/session.ts

+  async authenticate(
+    request: RequestWithSession,
+  ): Promise<UserProfile | RedirectRoute | undefined> {
+    if (!request.user) {


hmm why the session strategy doesn't retrieve the user from request's session but from request directly?

jannyHou · 2020-04-17T01:37:38Z

examples/passport-login/src/authentication-strategies/types.ts

+  done: (error: any, user?: any, info?: any) => void,
+) => void;
+
+export namespace PassportAuthenticationBindings {


please move the bindings into keys.ts file.

jannyHou · 2020-04-17T01:38:55Z

examples/passport-login/src/controllers/oauth2.controller.ts

+   */
+  loginToThirdParty(
+    @param.path.string('provider') provider: string,
+    @inject('authentication.redirect.url')


a reminder: doesn't have to apply in this PR, please create binding keys for the redirect url and status.

jannyHou

Thank you and please fix the lint error before merge: https://travis-ci.com/github/strongloop/loopback-next/jobs/320670018
And please also squash the commits and rename the first commit to be feat: since it's a code contribution with over 5k lines 🎉 .

deepakrkris force-pushed the passportfacebook branch 4 times, most recently from 45e0402 to 6a68ec4 Compare March 17, 2020 05:49

deepakrkris force-pushed the passportfacebook branch 6 times, most recently from 175eb29 to 0d84b39 Compare March 29, 2020 00:44

deepakrkris mentioned this pull request Mar 29, 2020

[Spike] Explore/research the oauth2+session based authentication strategy #2624

Closed

5 tasks

deepakrkris force-pushed the passportfacebook branch 2 times, most recently from 7b25fdf to 8b1d786 Compare March 30, 2020 17:12

emonddr suggested changes Mar 30, 2020

View reviewed changes

deepakrkris force-pushed the passportfacebook branch from 8b1d786 to 26b6d7c Compare March 30, 2020 18:30

jannyHou reviewed Mar 30, 2020

View reviewed changes

raymondfeng force-pushed the passportfacebook branch from 26b6d7c to df6288c Compare March 31, 2020 00:05

deepakrkris force-pushed the passportfacebook branch from df6288c to 038ae79 Compare March 31, 2020 08:25

deepakrkris marked this pull request as ready for review March 31, 2020 08:27

deepakrkris requested review from bajtos, hacksparrow and raymondfeng as code owners March 31, 2020 08:27

deepakrkris force-pushed the passportfacebook branch 3 times, most recently from 4dce345 to 0f5b8c3 Compare March 31, 2020 18:19

bajtos mentioned this pull request Mar 31, 2020

How to migrate apps using loopback-component-passport #3958

Closed

5 tasks

raymondfeng reviewed Mar 31, 2020

View reviewed changes

deepakrkris force-pushed the passportfacebook branch 5 times, most recently from 1c027c3 to 0c72bef Compare April 13, 2020 07:06

emonddr suggested changes Apr 14, 2020

View reviewed changes

jannyHou reviewed Apr 14, 2020

View reviewed changes

deepakrkris self-assigned this Apr 15, 2020

deepakrkris force-pushed the passportfacebook branch 2 times, most recently from 5d6de44 to d501f45 Compare April 15, 2020 18:10

emonddr suggested changes Apr 16, 2020

View reviewed changes

jannyHou approved these changes Apr 17, 2020

View reviewed changes

jannyHou approved these changes Apr 20, 2020

View reviewed changes

feat: migrate loopback-example-passport repo as lb4 example

24b5fec

deepakrkris force-pushed the passportfacebook branch from fda0515 to 24b5fec Compare April 20, 2020 18:40

deepakrkris merged commit dd3c328 into master Apr 20, 2020

deepakrkris deleted the passportfacebook branch April 20, 2020 19:33

		@@ -0,0 +1,68 @@
		// Copyright IBM Corp. 2019. All Rights Reserved.
		// Node module: @loopback/rest


		import {Entity, model, property} from '@loopback/repository';

		@model({settings: {strict: false}})

		@@ -0,0 +1,93 @@
		// Copyright IBM Corp. 2014,2015. All Rights Reserved.
		// Node module: loopback-example-passport

docs: migrate loopback-example-passport repo as lb4 example #4899

docs: migrate loopback-example-passport repo as lb4 example #4899

Conversation

deepakrkris commented Mar 16, 2020 • edited Loading

Test steps

Checklist

emonddr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emonddr commented Apr 13, 2020

deepakrkris commented Apr 13, 2020

deepakrkris commented Apr 13, 2020

deepakrkris commented Apr 13, 2020

deepakrkris commented Apr 13, 2020

deepakrkris commented Apr 13, 2020

deepakrkris commented Apr 13, 2020

emonddr commented Apr 13, 2020

deepakrkris commented Apr 13, 2020

emonddr commented Apr 13, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emonddr commented Apr 14, 2020

emonddr commented Apr 14, 2020 • edited Loading

jannyHou left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deepakrkris commented Apr 15, 2020

emonddr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jannyHou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jannyHou Apr 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deepakrkris commented Mar 16, 2020 •

edited

Loading

emonddr commented Apr 13, 2020 •

edited

Loading

emonddr commented Apr 14, 2020 •

edited

Loading

jannyHou left a comment •

edited

Loading

jannyHou Apr 17, 2020 •

edited

Loading

jannyHou left a comment •

edited

Loading