feat(authentication): extend TokenService for revokeable tokens #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derdeka
requested review from
emonddr,
hacksparrow and
jannyHou
as code owners
derdeka
added
developer-experience
raymondfeng
reviewed
Feb 26, 2020
derdeka
force-pushed
the
feat/authentication/extend-tokenservice
branch
from
1968c77 to
650742e
Compare
raymondfeng
reviewed
Feb 26, 2020
derdeka
force-pushed
the
feat/authentication/extend-tokenservice
branch
from
650742e to
1c81e85
Compare
derdeka
force-pushed
the
feat/authentication/extend-tokenservice
branch
from
80fa72e to
0c68cab
Compare
|
@strongloop/loopback-maintainers PTAL |
emonddr
approved these changes
Mar 10, 2020
|
@raymondfeng May i ask for your approvement again to get this landed? |
raymondfeng
approved these changes
Mar 11, 2020
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing token systems other then
jwtthere is a need to revoke a token. I also discovered that there is a need to access theUserProfileof the current user to validate tokens in some token systems.Example usecases:
RefreshToken, e.g [POC] add refreshtoken to extend accessToken loopback4-example-shopping#537lb3AccessTokeninlb4Related to #4573.
With this PR I'm suggesting to change the
TokenServiceinterface.This is a BREAKING CHANGE.WDYT?
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈