Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migrate datasources from lb3 to lb4 #4343

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Conversation

nabdelgadir
Copy link
Contributor

@nabdelgadir nabdelgadir commented Dec 29, 2019

Add steps to migrate LB3 datasources to LB4. Closes #3946.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice write up, easy to understand! Just one comment

Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Add steps to migrate LB3 datasources to LB4
@nabdelgadir nabdelgadir merged commit a4ae384 into master Dec 31, 2019
@nabdelgadir nabdelgadir deleted the migrate-ds-docs branch December 31, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to migrate datasources from LB3 to LB4
3 participants