feat: add defineCrudRepositoryClass #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hacksparrow I am confused. The pull request says "Add defineCrudRepositoryClass - a helper to create named repository classes", but then it changes 24 files and introduces also a booter class. Can you please check? |
hacksparrow
force-pushed
the
feat/defineCrudRepositoryClass
branch
2 times, most recently
from
c498c64 to
f36784d
Compare
|
@bajtos PTAL, updated. |
emonddr
approved these changes
Oct 4, 2019
bajtos
suggested changes
Oct 4, 2019
hacksparrow
force-pushed
the
feat/defineCrudRepositoryClass
branch
from
f36784d to
32e6de5
Compare
bajtos
suggested changes
Oct 4, 2019
hacksparrow
force-pushed
the
feat/defineCrudRepositoryClass
branch
from
32e6de5 to
13749fe
Compare
raymondfeng
reviewed
Oct 4, 2019
hacksparrow
force-pushed
the
feat/defineCrudRepositoryClass
branch
from
13749fe to
0347afc
Compare
emonddr
approved these changes
Oct 30, 2019
hacksparrow
force-pushed
the
feat/defineCrudRepositoryClass
branch
3 times, most recently
from
e15cdb0 to
52c3020
Compare
bajtos
reviewed
Oct 31, 2019
hacksparrow
force-pushed
the
feat/defineCrudRepositoryClass
branch
2 times, most recently
from
b2d9b60 to
bc42658
Compare
bajtos
reviewed
Oct 31, 2019
hacksparrow
force-pushed
the
feat/defineCrudRepositoryClass
branch
3 times, most recently
from
0686f2c to
fce609b
Compare
bajtos
reviewed
Nov 1, 2019
bajtos
reviewed
Nov 1, 2019
packages/rest-crud/README.md
Outdated
| ```ts | ||
| const db = new juggler.DataSource({connector: 'memory'}); | ||
| const ProductRepository = defineCrudRepositoryClass(Product); | ||
| const repo = new ProductRepository(db); |
There was a problem hiding this comment.
I find it confusing that the Controller section is showing DI + app.controller, but the Repository section is showing manual approach, which also does not take into account different lifetimes of a datasource (one instance for entire app life) vs. a repository (new repository created for each request).
hacksparrow
force-pushed
the
feat/defineCrudRepositoryClass
branch
from
fce609b to
38b902d
Compare
bajtos
approved these changes
Nov 1, 2019
Add `defineCrudRepositoryClass` - a helper to create named repository classes
hacksparrow
force-pushed
the
feat/defineCrudRepositoryClass
branch
from
38b902d to
091d8c4
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
defineCrudRepositoryClass- a helper to create named repository classes.Addresses #3733.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈