Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement TestSandbox.writeTextFile #3824

Merged
merged 1 commit into from
Sep 27, 2019
Merged

feat: implement TestSandbox.writeTextFile #3824

merged 1 commit into from
Sep 27, 2019

Conversation

hacksparrow
Copy link
Contributor

@hacksparrow hacksparrow commented Sep 27, 2019 •
edited
Loading

Add writeTextFile method to TestSandbox.

Addresses #3731.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

bajtos
bajtos reviewed Sep 27, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, let's discuss few minor details.

packages/testlab/src/test-sandbox.ts Outdated Show resolved Hide resolved
feat: implement TestSandbox.writeTextFile
a5c964d 
Add `writeTextFile` method to `TestSandbox`
@hacksparrow hacksparrow force-pushed the testsanbox/write-text-file branch from 5595fca to a5c964d Compare September 27, 2019 09:22
@hacksparrow
Copy link
Contributor Author

@bajtos thanks for the feedback. Updated.

@hacksparrow hacksparrow self-assigned this Sep 27, 2019
@hacksparrow hacksparrow merged commit 59ca3a0 into master Sep 27, 2019
@hacksparrow hacksparrow deleted the testsanbox/write-text-file branch September 27, 2019 13:36
@hacksparrow hacksparrow mentioned this pull request Sep 27, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees

@hacksparrow hacksparrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacksparrow @bajtos