fix: user profile to principal #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannyHou
commented
Sep 25, 2019
| import {Principal, securityId, UserProfile} from '@loopback/security'; | ||
|
|
||
| // This is a workaround before we specify `TypedPrincipal` instead of | ||
| // `Principal` for the principals in the authorization context. |
There was a problem hiding this comment.
The change will be addressed as part of #2246 or as a follow-up story after the spike done.
7 tasks
raymondfeng
reviewed
Sep 26, 2019
packages/authorization/src/util.ts
Outdated
| * user profile | ||
| * @param user The user profile passed from `@loopback/authentication`. | ||
| */ | ||
| export function userProfileToPrincipalBuilder(user: UserProfile): Principal { |
There was a problem hiding this comment.
Maybe name it as createPrincipalFromUserProfile?
jannyHou
force-pushed
the
update/authorize
branch
2 times, most recently
from
c801f0f to
5ff27b6
Compare
jannyHou
force-pushed
the
update/authorize
branch
from
5ff27b6 to
05ea968
Compare
raymondfeng
approved these changes
Sep 26, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3766 and #3707
Since PR #3796 is created earlier I would like to respect @derdeka 's contribution, feel free to take code from this PR to save your time on adding tests/code refactor.
My only concern for #3796 is explained in comment, after fixing it we can land it, then see if my PR still needed(improve #3796 or close it).