Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update generators #3791

Merged
merged 1 commit into from
Sep 23, 2019
Merged

docs: update generators #3791

merged 1 commit into from
Sep 23, 2019

Conversation

jannyHou
Copy link
Contributor

Update the Todo tutorial according to changes in model generator and controller generator

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@agnes512
Copy link
Contributor

Do we have any documentation for required setting in Model and the omit id setting in Controller? The one we fixed in #3667?

@jannyHou jannyHou force-pushed the docs/update-generators branch from 961d7ce to b6bc637 Compare September 23, 2019 17:08
@jannyHou
Copy link
Contributor Author

@agnes512 Added more doc for the model cli generator. PTAL thanks.

Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my question was about the required id in model and the omit id setting in the controller.

And I just saw the PR For controller generator, infer id omitted from the existing model class file #3757. If users don't have to answer an extra prompt about omitting id when they set id as required, this PR looks good to me.

@jannyHou jannyHou merged commit b2f3898 into master Sep 23, 2019
@jannyHou jannyHou deleted the docs/update-generators branch September 23, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants