fix(repository-json-schema): allow recursive model definitions

packages/repository-json-schema/src/__tests__/unit/build-schema.unit.ts

@@ -4,6 +4,9 @@
 // License text available at https://opensource.org/licenses/MIT
 
 import {
+  Model,
+  model,
+  property,
   PropertyDefinition,
   RelationDefinitionBase,
   RelationType,
@@ -13,6 +16,7 @@ import {
   buildModelCacheKey,
   getNavigationalPropertyForRelation,
   metaToJsonProperty,
+  modelToJsonSchema,
   stringTypeToWrapper,
 } from '../..';
 
@@ -200,6 +204,39 @@ describe('build-schema', () => {
     });
   });
 
+  describe('modelToJsonSchema', () => {
+    it('allows recursive model definition', () => {
+      @model()
+      class ReportState extends Model {
+        @property.array(ReportState, {})
+        states: ReportState[];
+
+        @property({
+          type: 'string',
+        })
+        benchmarkId?: string;
+
+        @property({
+          type: 'string',
+        })
+        color?: string;
+
+        constructor(data?: Partial<ReportState>) {
+          super(data);
+        }
+      }
+      const schema = modelToJsonSchema(ReportState, {});
+      expect(schema.properties).to.containEql({
+        states: {
+          type: 'array',
+          items: {$ref: '#/definitions/ReportState'},
+        },
+        benchmarkId: {type: 'string'},
+        color: {type: 'string'},
+      });
+    });
+  });
+
   describe('getNavigationalPropertyForRelation', () => {
     it('errors out if targetsMany is undefined', () => {
       expect(() =>

packages/repository-json-schema/src/build-schema.ts

@@ -397,7 +397,7 @@ export function modelToJsonSchema<T extends object>(
     result.definitions = result.definitions || {};
 
     // promote nested definition to the top level
-    if (schema.definitions) {
+    if (result !== schema && schema.definitions) {
       for (const key in schema.definitions) {
         if (key === title) continue;
         result.definitions[key] = schema.definitions[key];