-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add mounting lb3 app on lb4 migration guide #3052
Conversation
[Getting started](Getting-started.md) for an introduction. | ||
" %} | ||
|
||
1. To mount your LoopBack 3 application, you will need to first create a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following part is the same as https://github.com/strongloop/loopback-next/blob/master/examples/lb3-application/README.md#tutorial, so I'm wondering if I should just link to there instead or keep it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest avoid copy paste duplicate content so that everytime we only update one place, and other places link to the source page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point! I'll link then, thank you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nabdelgadir, I have 2 questions (in the review comments), not entirely about the changes you added, because I believe you've just moving the contents around, so I'm happy to open a new issue to discuss that if it's blocking the landing of your PR. Thanks.
|
||
- How to connect LoopBack 3.x concepts to LoopBack 4 terms | ||
- What's new and exciting in LoopBack 4 | ||
- What's on the roadmap to achieve functional parity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think roadmap is no longer part of this page?
This article will help existing users understand LoopBack 4: | ||
|
||
- How to connect LoopBack 3.x concepts to LoopBack 4 terms | ||
- What's new and exciting in LoopBack 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're in this page.. I'm thinking whether we should have "what's new and exciting in LB4" (this bullet and the section at the bottom), because the list keeps changing.
I'm happy to open another issue to discuss this, and not blocking the landing of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this but let me know if I should just remove the whole section instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I personally prefer to have it completely. Let's keep it this way for now and we can improve the docs later. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The refactor LGTM, I left a comment regarding the same content from the example tutorial
LoopBack 4 application. | ||
|
||
```sh | ||
$ lb4 app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of questions posed by this command, what do you suggest they specify?
154513f
to
bdacc61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TBH, I personally prefer to have the section "What's new and exciting in LoopBack 4" completely, but others might have other opinions. Let's keep it this way for now and we can improve the docs if needed. Thanks. |
8418c96
to
81b2de7
Compare
81b2de7
to
e60ccd1
Compare
Connect to #2393.
Docs describing using
Lb3AppBooterComponent
to mount a LoopBack 3 application on a LoopBack 4 project.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈