-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: include user and token service interfaces in index.ts #2875
Conversation
this PR also removes an empty interface (session interface) we are not implementing at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to export these interfaces if they are needed by consumers.
IMO, this change is a regular feature (we are adding new public API), not a refactoring. The commit message should use feat
type, not refactor
.
See https://en.wikipedia.org/wiki/Code_refactoring (emphasis is mine):
Code refactoring is the process of restructuring existing computer code without changing its external behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Hi Miroslav, this PR is a |
cbdbf84
to
8d80270
Compare
changed the commit type from refactor to fix based on a discussion with @bajtos . |
Include user and token service interfaces in ./service.index.ts and ./index.ts
8d80270
to
c64ba06
Compare
Include user and token service interfaces
in ./service.index.ts and ./index.ts
While refactoring the shopping cart application to use the latest authentication package, I noticed the newly added
user and token service interfaces in the services folder from the feat: design auth system with user scenario PR weren't added to an index.ts in the
services folder, and that the main index.ts doesn't include all exports from the ./services folder.
Before the shopping application refactor PR lands, this PR (which updates to the @loopback/authenticate package) must land.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈