Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document hasMany/belongsTo/hasOne limitations for NoSQL databases #2756

Merged
merged 1 commit into from
Apr 17, 2019
Merged

docs: document hasMany/belongsTo/hasOne limitations for NoSQL databases #2756

merged 1 commit into from
Apr 17, 2019

Conversation

hacksparrow
Copy link
Contributor

Documented hasMany/belongsTo/hasOne limitations for NoSQL databases.

Addresses #2340.

@hacksparrow hacksparrow requested a review from b-admike April 15, 2019 14:13
@hacksparrow hacksparrow force-pushed the docs/nosql-limitations branch from 7cd5636 to 3a997b6 Compare April 15, 2019 14:15
@hacksparrow hacksparrow force-pushed the docs/nosql-limitations branch from 3a997b6 to e7d22b8 Compare April 16, 2019 06:19
@hacksparrow
Copy link
Contributor Author

Thanks @raymondfeng, I have updated the files to address the issues pointed out by you.

bajtos
bajtos reviewed Apr 16, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, I have two minor comments.

docs/site/BelongsTo-relation.md Outdated Show resolved Hide resolved
docs/site/Relations.md Outdated Show resolved Hide resolved
@hacksparrow hacksparrow force-pushed the docs/nosql-limitations branch from e7d22b8 to 041895c Compare April 16, 2019 09:39
@hacksparrow
Copy link
Contributor Author

Thanks @bajtos, I have added the links.

bajtos
bajtos approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more small comments, no further review is necessary as far as I am concerned. Please get at least one more person to approve the changes before landing.

docs/site/HasMany-relation.md Outdated Show resolved Hide resolved
docs/site/Relations.md Outdated Show resolved Hide resolved
docs/site/hasOne-relation.md Outdated Show resolved Hide resolved
@hacksparrow hacksparrow self-assigned this Apr 17, 2019
@hacksparrow hacksparrow force-pushed the docs/nosql-limitations branch from 041895c to 60ad587 Compare April 17, 2019 07:54
docs: document hasMany/belongsTo/hasOne limitations for NoSQL databases
8ab9947 
Documented hasMany/belongsTo/hasOne limitations for NoSQL databases.
@hacksparrow hacksparrow force-pushed the docs/nosql-limitations branch from 60ad587 to 8ab9947 Compare April 17, 2019 13:04
@hacksparrow hacksparrow merged commit 6df4561 into master Apr 17, 2019
@b-admike b-admike deleted the docs/nosql-limitations branch April 17, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng raymondfeng left review comments

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@bajtos bajtos bajtos approved these changes

@b-admike b-admike Awaiting requested review from b-admike

Assignees

@hacksparrow hacksparrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hacksparrow @raymondfeng @bajtos @nabdelgadir