fix(cli): prepare the string of all model settings and use it in the… #2601
Conversation
…template prepare the string of all model settings and use it in the template, fix one test and add the new one to test this case fix loopbackio#2522
yanamg7
requested review from
b-admike,
bajtos,
hacksparrow,
jannyHou,
marioestradarosa,
nabdelgadir and
raymondfeng
as code owners
| import {model, property} from '@loopback/repository'; | ||
| import {<%= modelBaseClass %>} from '.'; | ||
| <% } -%> | ||
| import {<%= modelBaseClass %>, model, property} from '@loopback/repository'; |
There was a problem hiding this comment.
Please revert unrelated white-space changes.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@loopback/benchmark", | |||
| "version": "1.1.12", | |||
| "version": "1.1.13", | |||
There was a problem hiding this comment.
Please revert changes in all package-lock files.
I believe we are no longer including LB4 packages in our lock files, see 1d658fb
|
@yanamg7 , i saw you have another PR #2604, possibly for the same purpose. Does it mean this PR should be closed? Please note that you don't need to open another PR for pushing more changes. Here is a detailed instruction in submitting/modifying a PR: https://loopback.io/doc/en/lb4/submitting_a_pr.html. Thanks. |
|
Reverted and add new pull request, this one is not relevant already |
In the future, please rebase your existing pull request on top of the new In case you are not familiar with Git history rewriting, you can learn more in our docs: https://loopback.io/doc/en/contrib/code-contrib.html#how-to-rebase-your-branch. The important part is to use |
… template
prepare the string of all model settings and use it in the template, fix one test and add the new
one to test this case
fix #2522
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated