Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note to todo tutorial patch #2140

Merged
merged 1 commit into from
Dec 11, 2018
Merged

docs: add note to todo tutorial patch #2140

merged 1 commit into from
Dec 11, 2018

Conversation

nabdelgadir
Copy link
Contributor

@nabdelgadir nabdelgadir commented Dec 10, 2018 •
edited
Loading

Added a note to the Todo tutorial regarding using PATCH.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@nabdelgadir nabdelgadir force-pushed the update-todo-tutorial-patch branch from 6a65e6b to f15cce2 Compare December 10, 2018 16:58
@nabdelgadir nabdelgadir changed the title docs: update todo tutorial patch body docs: add note to todo tutorial patch Dec 10, 2018
@nabdelgadir nabdelgadir force-pushed the update-todo-tutorial-patch branch 4 times, most recently from ac10711 to 0e1bcc2 Compare December 10, 2018 19:57
@nabdelgadir nabdelgadir self-assigned this Dec 10, 2018
@nabdelgadir nabdelgadir force-pushed the update-todo-tutorial-patch branch from 0e1bcc2 to 520043c Compare December 10, 2018 20:42
bajtos
bajtos approved these changes Dec 11, 2018
View reviewed changes
docs/site/todo-tutorial-putting-it-together.md Outdated Show resolved Hide resolved
@nabdelgadir nabdelgadir force-pushed the update-todo-tutorial-patch branch from 520043c to b713620 Compare December 11, 2018 13:44
@nabdelgadir nabdelgadir merged commit 34d2e81 into master Dec 11, 2018
@nabdelgadir nabdelgadir deleted the update-todo-tutorial-patch branch December 11, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-admike b-admike b-admike approved these changes

@jannyHou jannyHou jannyHou approved these changes

@bajtos bajtos bajtos approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees

@nabdelgadir nabdelgadir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nabdelgadir @bajtos @jannyHou @b-admike