Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain express in crafting loopback 4 #1630

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Conversation

virkt25
Copy link
Contributor

@virkt25 virkt25 commented Aug 21, 2018

fixes #1538

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@virkt25 virkt25 self-assigned this Aug 21, 2018
@virkt25 virkt25 added this to the August Milestone milestone Aug 21, 2018
In contrast, LoopBack is designed to facilitate API creation and composition
by conventions and patterns as best practices. More types of constructs are
introduced.
### Why Express Still?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to have Why Express behind the scene?

#### Circling back to Express with a twist

LoopBack does a lot of things but our value add is the ease of use and data
processing, not middleware and routing so we didn't want to reinvent the wheel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Routing is the part we want to optimize based on controller metadata. As a result, we minimize the usage of Express routing.

Copy link
Contributor

@shimks shimks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


#### Circling back to Express with a twist

LoopBack does a lot of things but our value add is the ease of use and data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by but our value add is ...

only for their middleware support). The final decision was to use Express in a
way that bridges the gap by addressing the gaps identified above as follows:

- LoopBack provides it's own
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's -> its

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@virkt25 virkt25 force-pushed the docs-crafting-lb4 branch from 7876395 to c404f72 Compare August 21, 2018 20:35
@virkt25 virkt25 force-pushed the docs-crafting-lb4 branch from c404f72 to a42898f Compare August 21, 2018 21:01
@virkt25 virkt25 merged commit 3226643 into master Aug 21, 2018
@virkt25 virkt25 deleted the docs-crafting-lb4 branch August 21, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Update Why Not Express section in Crafting LoopBack 4
4 participants