[PoC] feat(rest): add type coercion for parseParams #1285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
reviewed
Apr 26, 2018
| const coercedParamArgs: OperationArgs = []; | ||
| for (const arg of paramArgs) { | ||
| debug('Coercing parameter', arg); | ||
| coercedParamArgs.push(typeof arg === 'object' ? arg : coerce(arg)); |
There was a problem hiding this comment.
Strictly speaking, it's about deserializing parameters from an http request. We have to respect the parameter type spec as illustrated in #941.
There was a problem hiding this comment.
That makes sense, I was working on using the deserializers from @repository and was really wondering why we couldn't use a simple coercer. I'll revert this to what it is in the original PoC
|
Not in line with what coercion entailed; it needs to use the OpenAPI v3 spec. Closing in favor of #1256 (which may be divided up). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated