-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(openapi-spec-builder): update README code snippet to v3 #1203
Conversation
@slnode test please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhmlau thank you! LGTM just a nitpick
const spec = { | ||
basePath: '/', | ||
swagger: '2.0', | ||
const spec3 = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: spec
is good I think :) Since we only support one version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right. We were copying over from the test file. Switching back to spec
.
Update README in https://github.com/strongloop/loopback-next/tree/master/packages/openapi-spec-builder
related to #988