Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(openapi-spec-builder): update README code snippet to v3 #1203

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Mar 28, 2018

@dhmlau
Copy link
Member Author

dhmlau commented Mar 28, 2018

@slnode test please

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhmlau thank you! LGTM just a nitpick

const spec = {
basePath: '/',
swagger: '2.0',
const spec3 = {
Copy link
Contributor

@jannyHou jannyHou Mar 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: spec is good I think :) Since we only support one version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right. We were copying over from the test file. Switching back to spec.

@dhmlau dhmlau merged commit e31961f into master Mar 29, 2018
@dhmlau dhmlau removed the review label Mar 29, 2018
@bajtos bajtos deleted the openapi-readme branch June 5, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants