Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: polish Dependency Injection article #1192

Merged
merged 1 commit into from
Mar 27, 2018
Merged

docs: polish Dependency Injection article #1192

merged 1 commit into from
Mar 27, 2018

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Mar 27, 2018 •
edited
Loading

Small improvements of Dependency Injection.

See #988

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

@bajtos bajtos self-assigned this Mar 27, 2018
shimks
shimks suggested changes Mar 27, 2018
View reviewed changes
docs/PULL-REQUESTS.md Outdated
@@ -0,0 +1,281 @@
# Developing LoopBack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file was staged accidentally 😆

docs/site/Dependency-injection.md Outdated
@@ -1,13 +1,3 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need the header here?

@bajtos
Copy link
Member Author

bajtos commented Mar 27, 2018

@shimks good points, I should have double-checked the patch myself before opening a pull request 🙈 Let me quickly fix those two problems.

@bajtos bajtos force-pushed the docs/dependency-injection-concept branch from 24026ac to 337cb2e Compare March 27, 2018 14:59
@bajtos bajtos force-pushed the docs/dependency-injection-concept branch from 337cb2e to 6105cd5 Compare March 27, 2018 15:30
@bajtos bajtos merged commit e770208 into master Mar 27, 2018
@bajtos bajtos deleted the docs/dependency-injection-concept branch March 27, 2018 16:43
@bajtos bajtos removed the review label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimks shimks shimks approved these changes

@b-admike b-admike b-admike approved these changes

@virkt25 virkt25 virkt25 approved these changes

@jannyHou jannyHou Awaiting requested review from jannyHou

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees

@bajtos bajtos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bajtos @virkt25 @b-admike @shimks