Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(context): update code in readme #1181

Merged
merged 1 commit into from
Mar 27, 2018
Merged

docs(context): update code in readme #1181

merged 1 commit into from
Mar 27, 2018

Conversation

virkt25
Copy link
Contributor

@virkt25 virkt25 commented Mar 23, 2018

connected to #988

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

@virkt25 virkt25 requested a review from a team March 23, 2018 18:16
@virkt25 virkt25 added this to the March 2018 milestone Mar 23, 2018
@virkt25 virkt25 self-assigned this Mar 23, 2018
@shimks
Copy link
Contributor

shimks commented Mar 23, 2018

Could you update #988 again, everytime I do something there, it reverts the most randomest things :|

@virkt25 virkt25 merged commit 2e4c8bc into master Mar 27, 2018
@virkt25 virkt25 deleted the docs/context branch March 27, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimks shimks shimks approved these changes

@b-admike b-admike b-admike approved these changes

@raymondfeng raymondfeng raymondfeng approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees

@virkt25 virkt25

Labels
None yet
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@virkt25 @shimks @raymondfeng @b-admike