docs: update contribution guidelines link and minor fixes #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virkt25
requested review from
b-admike,
bajtos,
jannyHou,
raymondfeng and
shimks
as code owners
dhmlau
approved these changes
Mar 23, 2018
bajtos
approved these changes
Mar 23, 2018
README.md
Outdated
| |Janny Hou|Simon Ho|Kevin Delisle|Rand McKinney| | ||
| |[<img src="https://avatars2.githubusercontent.com/u/12554153?v=3&s=60">](http://github.com/jannyHou)|[<img src="https://avatars1.githubusercontent.com/u/1617364?v=3&s=60">](http://github.com/superkhau)|[<img src="https://avatars3.githubusercontent.com/u/2053534?v=3&s=60">](http://github.com/kjdelisle)|[<img src="https://avatars2.githubusercontent.com/u/2925364?v=3&s=60">](http://github.com/crandmck)| | ||
| |[![jannyhou]](http://github.com/jannyHou)|[![superkhau]](http://github.com/superkhau)|[![kjdelisle]](http://github.com/kjdelisle)|[![crandmck]](http://github.com/crandmck)| |
There was a problem hiding this comment.
Please remove both kjdelisle and crandmck, they are no longer maintaining the project.
packages/build/README.md
Outdated
| @@ -12,7 +12,7 @@ This module contains a set of common scripts and default configurations to build | |||
|
|
|||
| These scripts first try to locate the CLI from target project dependencies and fall back to bundled ones in `@loopback/build`. | |||
|
|
|||
| # Usage | |||
| ## Usage | |||
There was a problem hiding this comment.
FWIW, according to our README guidelines, the correct name for this section is Basic use.
virkt25
force-pushed
the
docs/contributing-link
branch
from
6a09fa6 to
e3599cb
Compare
shimks
reviewed
Mar 23, 2018
| @@ -204,7 +204,7 @@ strongly discouraged for a few reasons: | |||
|
|
|||
There was a problem hiding this comment.
Line 197: missing a close bracket here
shimks
approved these changes
Mar 23, 2018
raymondfeng
approved these changes
Mar 23, 2018
virkt25
force-pushed
the
docs/contributing-link
branch
from
d3842d4 to
2265034
Compare
virkt25
force-pushed
the
docs/contributing-link
branch
from
2265034 to
6fde719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected to #988
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated