-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove calling other apis page #1177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just remove the page from the sidebar and call it done? It'd be nicer to keep the page around as a reminder, but if an issue tracks what the page is supposed to remind us, then I'm happy with the changes.
There's only 3 bullets on the page. I think that's the obvious sections someone will write as they work on the docs after this feature is implemented. |
Maybe keeping the pages and adding a disclaimer to state such feature is to be implemented makes sense in this case for two reasons:
I won't block the PR if majority of us think it's better to remove. |
User can see features we have planned via WIP PR's and Issues. I don't think Docs is the place to show it but that said I'm not against keeping the page. @raymondfeng Do you think the current notice on the page is sufficient?
|
I slightly prefer Raymond's proposal to keep the page with the current TODO notice, but don't mind to remove the page either. |
Closing this PR as the page has a notice that this is a feature that is coming soon. |
connected to #988
Copy of loopbackio/loopback.io#641 since docs were migrated before that PR landed.
The entire page is a big To Do as the features haven't been implemented yet. I am proposing removing this page TILL these features are implemented at which point the docs have to be written anyways.
RATIONALE: There is no content worth keeping and as a user when I click the page I would expect to find information on how to accomplish what the title states instead of finding a page saying it's a feature to be added to the framework.
Checklist
npm test
passes on your machinepackages/cli
were updatedpackages/example-*
were updated