Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(example-hello-world): fix typos in README #1028

Merged
merged 1 commit into from
Feb 22, 2018
Merged

docs(example-hello-world): fix typos in README #1028

merged 1 commit into from
Feb 22, 2018

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Feb 22, 2018

In packages\example-hello-world README:

  • Update the prereq to be Node 8 or higher
  • fix typo for the directory name as loopback4-example-hello-world

Related to #988

@dhmlau dhmlau requested a review from b-admike as a code owner February 22, 2018 03:10
@dhmlau dhmlau merged commit 908d360 into master Feb 22, 2018
@dhmlau dhmlau deleted the hello-world branch February 22, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimks shimks shimks approved these changes

@kjdelisle kjdelisle kjdelisle approved these changes

@raymondfeng raymondfeng raymondfeng approved these changes

@b-admike b-admike Awaiting requested review from b-admike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhmlau @raymondfeng @kjdelisle @shimks