Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node.js 6.x #611

Closed
21 tasks done
bajtos opened this issue Oct 3, 2017 · 9 comments
Closed
21 tasks done

Drop support for Node.js 6.x #611

bajtos opened this issue Oct 3, 2017 · 9 comments
Assignees
Milestone

Comments

@bajtos
Copy link
Member

bajtos commented Oct 3, 2017

Considering that Node.js 6.x will enter maintenance mode long time before our expected GA release, we think it makes sense to require LoopBack Next users to run on Node.js 8.x or newer.

Tasks

@bajtos bajtos self-assigned this Oct 3, 2017
@richardpringle
Copy link

Node.js 8.x is supposed to enter LTS at the end of this month. With the amount of ECMAScript changes that version 8 supports, I don't think it would make sense to release a new product with legacy support.

I would be surprised if anyone is using LoopBack 4.x with any legacy modules that require Node.js 6...

But then again... what do I know? 😉

@bajtos bajtos added backlog and removed planning labels Oct 3, 2017
@bajtos
Copy link
Member Author

bajtos commented Oct 4, 2017

I would be surprised if anyone is using LoopBack 4.x with any legacy modules that require Node.js 6

This is not really about using modules written in Node.js 6.x style, those should be still usable in Node.js 8.x

It's about developers that don't have a full control of their production environment - e.g. they have an operations team managing their Node.js production environment, the company may have a policy that all apps should be running on the same Node.js major version, and it may take them a non-trivial amount of effort of time to upgrade the production machines (and all deployed apps) to run on Node.js 8.x.

@proreact-mj
Copy link

We are already running LB2 on Node 8, so I'm fine with it :)

Do we know of any usual suspects (modules often used in LB apps) that still lack Node 8 support and is not expected to do so at LB4 GA?

@proreact-mj
Copy link

It's about developers that don't have a full control of their production environment - e.g. they have an operations team managing their Node.js production environment

This is become less and less an issue with the popularity of containerization and serverless hosting options. If an operations team can provide support for the latest LTS version of Node.js, then they don't deserve the latest framework evolution 😈 IMHO

@richardpringle
Copy link

@bajtos, I know that there are some modules out there that won't even work with npm 5 on node 6. I'm guessing most (if not all) of the modules in question have native components.

As for those who do not have control over their production environments... hopefully they speak up on this thread!

@mpicard
Copy link

mpicard commented Oct 9, 2017 via email

@bajtos bajtos added the p2 label Oct 17, 2017
@virkt25
Copy link
Contributor

virkt25 commented Oct 31, 2017

Node 8 just went LTS and Node 6 will be entering Maintenance in April 2018. I think it's better to just support Node 8 and higher.

@bajtos bajtos added MVP and removed p2 labels Dec 12, 2017
@dhmlau
Copy link
Member

dhmlau commented Jan 9, 2018

As discussed, pulling this task into Planning per @bajtos request. This has been affecting our current development, and it's better to handle this earlier than later.

@bajtos bajtos changed the title RFC: drop support for Node.js 6.x Drop support for Node.js 6.x Jan 15, 2018
@kjdelisle kjdelisle added this to the February 2018 milestone Jan 30, 2018
@kjdelisle kjdelisle self-assigned this Jan 30, 2018
kjdelisle pushed a commit that referenced this issue Jan 30, 2018
Node 6 does not have support for new engine APIs like util.promisify, and is no longer the LTS
version of Node.js, so we are dropping support to ensure that LoopBack 4 remains on the cutting
edge.

BREAKING CHANGE: Node 6 is no longer supported. Upgrade to Node 8 or higher.

closes #611
@bajtos
Copy link
Member Author

bajtos commented Feb 1, 2018

https://github.com/strongloop-archive/loopback4-extension-typeorm

I wanted to write that we don't have to change this example because it's deprecated, but then I looked at its package.json and found that it already supports only Node.js 8+:

https://github.com/strongloop-archive/loopback4-extension-typeorm/blob/ce1414c97670b0bd6f0648a55778a9aaa5ecc222/package.json#L9-L11

I'll mark this task as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants