Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Implement a local commit linter using Husky #585

Closed
virkt25 opened this issue Sep 21, 2017 · 3 comments · Fixed by #1394
Closed

ci: Implement a local commit linter using Husky #585

virkt25 opened this issue Sep 21, 2017 · 3 comments · Fixed by #1394
Assignees
Labels
developer-experience Issues affecting ease of use and overall experience of LB users

Comments

@virkt25
Copy link
Contributor

virkt25 commented Sep 21, 2017

Currently commitlint is configured to run on Travis. It is possible to configure it to run commitlint locally using Husky by tying into the commithook. This will allow developers to know if their commit message is valid when they write it instead of waiting to figure out once Travis is done running.

We would still keep the Travis check as an enforcement but this will make developer / contributor experience for @loopback more pleasant.

@dhmlau
Copy link
Member

dhmlau commented Sep 27, 2017

@virkt25 , as discussed, this can be a core GA item. thanks.

@bajtos bajtos added the non-MVP label Nov 2, 2017
@bajtos bajtos added the developer-experience Issues affecting ease of use and overall experience of LB users label Dec 15, 2017
@kjdelisle
Copy link
Contributor

@dhmlau @Raymond I think we should do this sooner. Waiting on remote CI to validate my commit messages is a very large time sink and handling it before it gets pushed to a PR is a must, IMO.

@dhmlau
Copy link
Member

dhmlau commented Jan 17, 2018

Agree that we need commit linter to be run locally, not waiting for CI to fail just because of the commit message. :)
I'll leave the choice of using Husky (or other alternatives) to the team.

@virkt25 virkt25 self-assigned this Jun 5, 2018
@virkt25 virkt25 added this to the June Milestone milestone Jun 5, 2018
virkt25 added a commit that referenced this issue Jun 5, 2018
fixes #585

Signed-off-by: Taranveer Virk <[email protected]>
virkt25 added a commit that referenced this issue Jun 5, 2018
fixes #585

Signed-off-by: Taranveer Virk <[email protected]>
virkt25 added a commit that referenced this issue Jun 5, 2018
fixes #585

Signed-off-by: Taranveer Virk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Issues affecting ease of use and overall experience of LB users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants