-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Implement a local commit linter using Husky #585
Labels
developer-experience
Issues affecting ease of use and overall experience of LB users
Milestone
Comments
@virkt25 , as discussed, this can be a core GA item. thanks. |
bajtos
added
the
developer-experience
Issues affecting ease of use and overall experience of LB users
label
Dec 15, 2017
Agree that we need commit linter to be run locally, not waiting for CI to fail just because of the commit message. :) |
virkt25
added a commit
that referenced
this issue
Jun 5, 2018
fixes #585 Signed-off-by: Taranveer Virk <[email protected]>
7 tasks
virkt25
added a commit
that referenced
this issue
Jun 5, 2018
fixes #585 Signed-off-by: Taranveer Virk <[email protected]>
virkt25
added a commit
that referenced
this issue
Jun 5, 2018
fixes #585 Signed-off-by: Taranveer Virk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently
commitlint
is configured to run on Travis. It is possible to configure it to run commitlint locally usingHusky
by tying into the commithook. This will allow developers to know if their commit message is valid when they write it instead of waiting to figure out once Travis is done running.We would still keep the Travis check as an enforcement but this will make developer / contributor experience for
@loopback
more pleasant.The text was updated successfully, but these errors were encountered: