chore: add repository-factory unit tests

loopbackio · Jun 11, 2018 · 572dc85 · 572dc85
1 parent 9c0524b
commit 572dc85
Show file tree

Hide file tree

Showing 4 changed files with 68 additions and 13 deletions.
diff --git a/packages/repository/src/repositories/constraint-utils.ts b/packages/repository/src/repositories/constraint-utils.ts
@@ -5,7 +5,7 @@
 
 import {Filter, WhereBuilder, Where, FilterBuilder} from '../query';
 import {AnyObject, DataObject} from '../common-types';
-import {cloneDeep, isArray} from 'lodash';
+import {cloneDeep} from 'lodash';
 import {Entity} from '../model';
 
 /**

diff --git a/packages/repository/src/repositories/relation.factory.ts b/packages/repository/src/repositories/relation.factory.ts
@@ -4,7 +4,6 @@
 // License text available at https://opensource.org/licenses/MIT
 
 import {EntityCrudRepository} from './repository';
-import {Class} from '../common-types';
 import {RelationType} from '../decorators/relation.decorator';
 import {Entity} from '../model';
 import {
@@ -14,9 +13,7 @@ import {
 
 export interface RelationDefinitionBase {
   type: RelationType;
-  modelFrom: Class<Entity> | string;
   keyTo: string;
-  keyFrom: string;
 }
 
 export interface HasManyDefinition extends RelationDefinitionBase {
@@ -38,7 +35,7 @@ export interface HasManyDefinition extends RelationDefinitionBase {
  * relation attached to a datasource.
  *
  */
-export function hasManyRepositoryFactory<SourceID, T extends Entity, ID>(
+export function relationRepositoryFactory<SourceID, T extends Entity, ID>(
   sourceModelId: SourceID,
   relationMetadata: HasManyDefinition,
   targetRepository: EntityCrudRepository<T, ID>,
@@ -47,9 +44,9 @@ export function hasManyRepositoryFactory<SourceID, T extends Entity, ID>(
     case RelationType.hasMany:
       const fkConstraint = {[relationMetadata.keyTo]: sourceModelId};
 
-      return new DefaultHasManyEntityCrudRepository(
-        targetRepository,
-        fkConstraint,
-      );
+      return new DefaultHasManyEntityCrudRepository<
+        T,
+        EntityCrudRepository<T, ID>
+      >(targetRepository, fkConstraint);
   }
 }
diff --git a/packages/repository/test/acceptance/has-many.relation.acceptance.ts b/packages/repository/test/acceptance/has-many.relation.acceptance.ts
@@ -10,7 +10,7 @@ import {
   DefaultCrudRepository,
   juggler,
   EntityCrudRepository,
-  hasManyRepositoryFactory,
+  relationRepositoryFactory,
   HasManyDefinition,
   RelationType,
 } from '../..';
@@ -40,7 +40,7 @@ describe('HasMany relation', () => {
       // The initial "involved" implementation is below
 
       //FIXME: should be automagically instantiated via DI or other means
-      const customerOrders = hasManyRepositoryFactory(
+      const customerOrders = relationRepositoryFactory(
         customerId,
         customerHasManyOrdersRelationMeta,
         orderRepo,
@@ -117,8 +117,6 @@ describe('HasMany relation', () => {
 
   function givenHasManyRelationMetadata(): HasManyDefinition {
     return {
-      modelFrom: Customer,
-      keyFrom: 'id',
       keyTo: 'customerId',
       type: RelationType.hasMany,
     };

diff --git a/packages/repository/test/unit/repositories/relation-factory.unit.ts b/packages/repository/test/unit/repositories/relation-factory.unit.ts
@@ -0,0 +1,60 @@
+import {
+  relationRepositoryFactory,
+  juggler,
+  DefaultCrudRepository,
+  Entity,
+  RelationDefinitionBase,
+  RelationType,
+  ModelDefinition,
+  HasManyDefinition,
+} from '../../../src';
+import * as RelationFactoryNamespace from '../../../src/repositories/relation.repository'; // needed to spy on the factory function
+import {sinon} from '@loopback/testlab';
+
+describe('relationRepositoryFactory', () => {
+  const instanceId = 4;
+  let meta: RelationDefinitionBase;
+  let relationTestRepo: DefaultCrudRepository<Entity, number>;
+  let db: juggler.DataSource;
+
+  before(givenDataSource);
+  before(givenTestRepository);
+
+  it('calls DefaultHasManyEntityCrudRepository constructor when given HasMany metadata', () => {
+    meta = {
+      type: RelationType.hasMany,
+      keyTo: 'hasManyId',
+    };
+    const spy = sinon.spy(
+      RelationFactoryNamespace,
+      'DefaultHasManyEntityCrudRepository',
+    );
+
+    relationRepositoryFactory(
+      instanceId,
+      meta as HasManyDefinition,
+      relationTestRepo,
+    );
+
+    sinon.assert.calledWithNew(spy);
+    sinon.assert.calledWith(spy, relationTestRepo, {hasManyId: instanceId});
+  });
+
+  function givenDataSource() {
+    db = new juggler.DataSource({connector: 'memory'});
+  }
+
+  function givenTestRepository() {
+    relationTestRepo = new DefaultCrudRepository(
+      class TestModel extends Entity {
+        static definition = new ModelDefinition({
+          name: 'TestModel',
+          properties: {
+            testId: {type: 'string', id: true},
+          },
+        });
+      },
+      db,
+    );
+  }
+});