fixup!: apply feedback

loopbackio · May 14, 2019 · 2ff383b · 2ff383b
1 parent d7e7f56
commit 2ff383b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/packages/authentication/src/__tests__/unit/providers/authentication.provider.unit.ts b/packages/authentication/src/__tests__/unit/providers/authentication.provider.unit.ts
@@ -65,8 +65,7 @@ describe('AuthenticateActionProvider', () => {
         expect(user).to.be.equal(mockUser);
       });
 
-      // This PoC is in progress, will recover the test asap
-      it.skip('throws an error if the injected passport strategy is not valid', async () => {
+      it('throws an error if the injected strategy is not valid', async () => {
         const context: Context = new Context();
         context
           .bind(AuthenticationBindings.STRATEGY)
@@ -84,7 +83,10 @@ describe('AuthenticateActionProvider', () => {
         } catch (exception) {
           error = exception;
         }
-        expect(error).to.have.property('message', 'invalid strategy parameter');
+        expect(error).to.have.property(
+          'message',
+          'strategy.authenticate is not a function',
+        );
       });
 
       it('throws Unauthorized error when authentication fails', async () => {

diff --git a/packages/authentication/src/__tests__/unit/strategy-adapter.unit.ts b/packages/authentication/src/__tests__/unit/strategy-adapter.unit.ts
@@ -20,11 +20,7 @@ describe('Strategy Adapter', () => {
         // override authenticate method to set calledFlag
         async authenticate(req: Request, options?: AuthenticateOptions) {
           calledFlag = true;
-          await MockPassportStrategy.prototype.authenticate.call(
-            this,
-            req,
-            options,
-          );
+          await super.authenticate.call(this, req, options);
         }
       }
       const strategy = new Strategy();