test(dao): bad filter for destroyAll

loopbackio · Jul 23, 2018 · 7fb58ea · 7fb58ea
1 parent 4d14c14
commit 7fb58ea
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/lib/utils.js b/lib/utils.js
@@ -302,7 +302,7 @@ function selectFields(fields) {
 }
 
 /**
- * Remove undefined values from the queury object
+ * Remove undefined values from the query object
  * @param query
  * @param handleUndefined {String} either "nullify", "throw" or "ignore" (default: "ignore")
  * @returns {exports.map|*}

diff --git a/test/basic-querying.test.js b/test/basic-querying.test.js
@@ -1026,6 +1026,36 @@ describe('basic-querying', function() {
     });
   });
 
+  describe('destroyAll', function() {
+    beforeEach(function resetFixtures(done) {
+      User.destroyAll(function() {
+        User.create([
+          {name: 'John'},
+          {name: 'Jane'},
+          {name: 'Mary'},
+        ], done);
+      });
+    });
+
+    after(function deleteFixtures(done) {
+      User.destroyAll(done);
+    });
+
+    it('should not delete all for bad where object', function(done) {
+      User.destroyAll({where: {name: 'Test'}}, function(err, info) {
+        should.not.exist(err);
+        User.find({fields: 'name'}, function(err, users) {
+          users.should.containDeep([
+            {name: 'John'},
+            {name: 'Jane'},
+            {name: 'Mary'},
+          ]);
+          done();
+        });
+      });
+    });
+  });
+
   context('regexp operator', function() {
     var invalidDataTypes = [0, true, {}, [], Function, null];