Add support for custom column mapping #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'type': 'String', 'required': true, 'length': 20, | ||
| 'mssql': { | ||
| 'columnName': 'LOCATION_ID', 'dataType': 'nvarchar', | ||
| 'nullable': 'N' |
There was a problem hiding this comment.
I find this style confusing. IMO you should either put all items on a single line, or else put each key/value pair on a new line.
|
I am not familiar with this code base. A superfluous inspection did not reveal any major issues. My main concern is whether the new tests cover all places you had to change? See also my style-related comments above. I'll leave the ultimate decision up to you, feel free to ignore my comments and merge the PR as it is now. |
raymondfeng
force-pushed
the
feature/fix-custom-column
branch
from
460e07e to
407d4e7
Compare
|
This solved relations? With not custom column mapping relations don't work. |
raymondfeng
force-pushed
the
feature/fix-custom-column
branch
from
407d4e7 to
30e5ee1
Compare
raymondfeng
added a commit
that referenced
this pull request
Feb 21, 2015
Add support for custom column mapping
|
Please send release to npm. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the support for mssql column mapping for model properties.
/to @ritch or @bajtos