Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: meaningful variable names #521

Merged
merged 1 commit into from
May 23, 2019
Merged

chore: meaningful variable names #521

merged 1 commit into from
May 23, 2019

Conversation

hacksparrow
Copy link
Contributor

@hacksparrow hacksparrow commented May 23, 2019 •
edited
Loading

Description

Renamed some variables to be more reflective about their nature, as per this discussion.

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

b-admike
b-admike approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes, glad to see these changes n a new PR.

bajtos
bajtos approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! 👍

@hacksparrow hacksparrow merged commit dc0b85f into master May 23, 2019
@bajtos bajtos deleted the rename-vars branch May 23, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-admike b-admike b-admike approved these changes

@bajtos bajtos bajtos approved these changes

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

@emonddr emonddr Awaiting requested review from emonddr

@jannyHou jannyHou Awaiting requested review from jannyHou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacksparrow @bajtos @b-admike