Run shared test from both v3 and v4 of juggler #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnes512
force-pushed
the
share-test
branch
2 times, most recently
from
ca8b57c to
b2ab8a4
Compare
emonddr
approved these changes
Feb 13, 2020
agnes512
commented
Feb 13, 2020
| @@ -18,7 +18,7 @@ | |||
| "lint": "eslint .", | |||
| "lint:fix": "eslint --fix .", | |||
| "pretest": "node pretest.js", | |||
| "test": "mocha --timeout 20000 --require test/init.js", | |||
| "test": "mocha --timeout 60000 --require test/init.js test/*.test.js node_modules/juggler-v3/test.js node_modules/juggler-v4/test.js", | |||
There was a problem hiding this comment.
Note: for whoever working on any similar tasks, adding timeout/making it longer may fix timing-related errors.
There was a problem hiding this comment.
Ideally, we should move the timeout configuration to test/mocha.opts or a mocha-rc file, so that we can run individual test files via npx mocha node_modules/juggler-v3/test.js and don't have to specify the timeout in CLI args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #79
Ref loopbackio/loopback-connector-postgresql#376
loopbackio/loopback-connector-mysql#390
loopbackio/loopback-connector-db2#144
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine