update node version to skip imported test for older version #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnes512
requested review from
b-admike,
dhmlau,
jannyHou and
virkt25
as code owners
jannyHou
reviewed
Jun 20, 2019
package.json
Outdated
| @@ -3,7 +3,7 @@ | |||
| "version": "2.3.0", | |||
| "description": "LoopBack Connector for IBM Cloudant DB", | |||
| "engines": { | |||
| "node": ">=6" | |||
| "node": ">=8.9" | |||
There was a problem hiding this comment.
another connector does https://github.com/strongloop/loopback-connector-mongodb/blob/master/package.json#L6 but loopback-next has 8.9 but do you think we should follow other connectors?
There was a problem hiding this comment.
@nabdelgadir @agnes512 Usually "8" is good, loopback-next restricts it to be above "8.9" because lower 8 versions don't work....But for connectors we don't have that problem.
agnes512
force-pushed
the
update-test-node-version
branch
from
292ceb1 to
0b4d752
Compare
dhmlau
approved these changes
Jun 20, 2019
jannyHou
approved these changes
Jun 20, 2019
bajtos
reviewed
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we are changing to execute tests from both juggler versions 3.x and 4.x, and juggler v4 does not support Node.js 6, update node configs to skip tests for Node.js 6.
Related issues
Checklist
guide