Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update/updateAll functions #151

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Fix update/updateAll functions #151

merged 1 commit into from
Jun 8, 2017

Conversation

ssh24
Copy link
Contributor

@ssh24 ssh24 commented Jun 7, 2017

Description

Return the result in updateAll in a correct manner. Check for error on update if any exists.

connect to #35

README.md Outdated
@@ -278,6 +278,18 @@ Let's say we have an instance in the database:
});
```

- update/updateAll

```javascript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also show an example without _rev here or note that it could be done

Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to rebase with master

@ssh24 ssh24 force-pushed the fix/updateAll branch 2 times, most recently from e6290d2 to 6458a69 Compare June 8, 2017 13:50
@ssh24 ssh24 merged commit abcd68b into master Jun 8, 2017
@ssh24 ssh24 deleted the fix/updateAll branch June 8, 2017 14:43
@ssh24 ssh24 removed the #review label Jun 8, 2017
@ssh24 ssh24 added this to the Sprint 37 - Apex milestone Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants