Upgrade translation support #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasecilu
force-pushed
the
enhancement/translation_support
branch
from
dbb3193 to
415d5da
Compare
hasecilu
force-pushed
the
enhancement/translation_support
branch
8 times, most recently
from
39c1308 to
282e07a
Compare
hasecilu
force-pushed
the
enhancement/translation_support
branch
from
282e07a to
9ca551c
Compare
Also include `translations/README.md` file with instructions.
Migrate some strings marked with `translate()` to use `QT_TRANSLATE_NOOP()`
hasecilu
force-pushed
the
enhancement/translation_support
branch
from
9ca551c to
d70bd7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned here #152 (comment), the current implementation of translation here is not optimal and with future potential translations it could cause bad rendering on accented characters, see example below:
lupdatefrom Qt6 because it allows to update files with strings from Python and UI at the same time, so, if in the future is needed there would not be problems.Superseeds #153Fix #151