support serving local folders using web-server-chrome #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I notice that when I enter a bad port (say 80 or rather any ports under 1024 I think?) the web server will fail to start, but there is no indication to the user why there was a failure. Perhaps it would make sense to validate the input, and have a way to show an error upon launching the kiosk app |
|
Roger that. I'll enforce client side. I was considering hiding the interface/port options entirely (just use 127.0.0.1:8080, or another random port).. but there could conceivably be a port conflict, so I'll probably allow it to be user configurable. |
matt-cook
added a commit
that referenced
this pull request
Mar 2, 2016
support serving local folders using web-server-chrome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything seems to be working. Only nitpick I notice so far is that if you change the password via the remote interface it does not restart the server nor update the auth credentials. I am not sure if this is desired. But you could update the .opts.auth data field if wanted...