fix: No results message not showing (#5)

* fix: No results message not showing * fix: Render using react * fix: Changed to a zero comparison
looker-open-source · Oct 5, 2023 · dba5e34 · dba5e34
1 parent 158fef4
commit dba5e34
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/packed_bubble.js b/packed_bubble.js
diff --git a/src/bubble_chart/bubble_chart_container.js b/src/bubble_chart/bubble_chart_container.js
@@ -91,6 +91,17 @@ looker.plugins.visualizations.add({
     // Clear any errors from previous updates
     this.clearErrors();
 
+    // Issue identified where viz would not change with table calc filters
+    // need to supply the container with something new if we fail early and
+    // don't make it to the inteded render function.
+    // https://looker.atlassian.net/browse/DX-5779
+    if (data.length === 0) {
+      this.addError({
+        title: "No Results",
+      });
+      return;
+    }
+
     const dimensions = [].concat(
       queryResponse.fields.dimensions,
       queryResponse.fields.table_calculations.filter(
@@ -120,13 +131,6 @@ looker.plugins.visualizations.add({
       });
       return;
     }
-    if (data.length === 0) {
-      this.addError({
-        title: "No Results",
-      });
-      done();
-      return;
-    }
 
     // const secondDimension = dimensions[1]
     const firstMeasure = measures[0];