feat: Misc fixes #175

drstrangelooker · 2023-04-13T20:51:04Z

Miscellaneous fixes

github-actions · 2023-04-13T20:55:27Z

Ruby-CI Tests

    4 files     4 suites 1m 17s ⏱️
136 tests 136 ✔️ 0 💤 0 ❌
544 runs 544 ✔️ 0 💤 0 ❌

Results for commit c72ed44.

jkaster

Looks good, but I have a request to use allowlist for a param

lib/gzr/commands/attribute.rb

github-actions · 2023-04-13T22:43:32Z

    4 files     4 suites 1m 20s ⏱️
136 tests 136 ✔️ 0 💤 0 ❌
544 runs 544 ✔️ 0 💤 0 ❌

Results for commit 139a4ce.

drstrangelooker added 5 commits April 12, 2023 19:55

feat: cache results of keys_to_keep lookups

10e1baf

fix: remove redefinition of :width to clear warnings

d4ab97b

fix: linting issues, better error messages

09273c6

fix: lint issues in unit tests

6ad76fa

fix: bump version to go with API 4.0 support

c72ed44

drstrangelooker changed the title ~~feat:Misc fixes~~ feat: Misc fixes Apr 13, 2023

drstrangelooker requested review from jkaster and deanlooker April 13, 2023 20:53

jkaster approved these changes Apr 13, 2023

View reviewed changes

lib/gzr/commands/attribute.rb Outdated Show resolved Hide resolved

feat: change whitelist to allowlist

139a4ce

drstrangelooker merged commit 20b334b into main Apr 13, 2023

drstrangelooker deleted the misc-fixes branch April 13, 2023 22:44

looker-open-source-automation-bot mentioned this pull request Apr 13, 2023

chore(main): release 0.3.0 #176

Merged

This comment has been minimized.

Sign in to view

looker-open-source-automation-bot mentioned this pull request Jul 19, 2024

chore(main): release 0.3.0 #259

Closed